Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js_format): fix js template element parentheses issue #3780

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix(js_format): fix js template element parentheses issue #3780

merged 2 commits into from
Sep 4, 2024

Conversation

suxin2017
Copy link
Contributor

Summary

fix #3766

Test Plan

add snap test

@github-actions github-actions bot added A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages labels Sep 4, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 4, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3780 will improve performances by 18.25%

Comparing suxin2017:fix_3766 (c4c497e) with main (3180697)

Summary

⚡ 1 improvements
✅ 106 untouched benchmarks

Benchmarks breakdown

Benchmark main suxin2017:fix_3766 Change
⚡ big5-added_15586211152145260264.json[uncached] 649.3 µs 549.1 µs +18.25%

Conaclos
Conaclos approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Conaclos Conaclos merged commit b367c68 into biomejs:main Sep 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conaclos Conaclos Conaclos approved these changes

Assignees
No one assigned
Labels
A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📝 Output is different based on initial formatting of input
2 participants
@suxin2017 @Conaclos